Ok at the risk of being crucified on the internet I have attached my diagram. Does this look like it would work?
I'm by no means P-J, but I'll see what I can do for you...
1 - Why do you have your plug between the main breaker box and the 50 amp spa panel? Do you intend to have your spa panel be movable? It seems like it would make more sense to have the plug be after the spa panel, so that the spa panel is hard wired in, and you only unplug the control panel.
2 - Regardless of your solution above, why are you going 4 wires to the plug, then 3 wires to the spa panel, then 4 wires to the control panel? It seems entirely logical and resonable to run 4 wires the entire way, and then you don't have to worry about trying to derive neutral from ground within the spa panel - sure, you can do it, but what's the point in cutting out the neutral (I'm assuming yellow is neutral in your diagram - there's no legend) in that short run?
3 - Make sure to check your wire sizes. If you're running a 4500w heating element at 240v, it'll pull roughly 18.75amps. A 12 gauge wire is not going to cut it. Additionally, if you're running a 50amp breaker, you need 4gauge wiring in the setup to the spa panel and to your control panel. Your 6ga wiring is rated to around 37amps, which means if you DID have an issue, your wiring could potentially burn up before the breaker ever trips. This is not a good plan.
4 - I don't think the volt / amp meter is as simple as you show it, given how Kal had to run his. Do you have a simple device that just plugs straight in and gives you all those values and can handle 20 or so amps that your element may be drawing?
5 - With the e-Stop, you show a direct connection between the hot leg and ground. When people wire it up in this manner there are typically a few resistors in the line to prevent you from flowing full voltage to ground. With the resistors you get a trickle that will kill the GFCI. In your way, you'll get a large spark and could fry some wires or components. Unless you just haven't shown them, which brings me to...
6 - You need more detail of what's actually in the panel. This is good from the macro perspective. Now do one of just the panel with a little more clarity.
And lastly - take the time to read the primer on this page and as much other information as you can to get smart on some of this stuff. You're asking questions which is a great place to start, but if you were to wire it up as you have shown you could cause some issues that range from minor hazard to possible house-engulfing fire. Keep up the learning process, you're on the right path!
-Kevin