I used to wait until the yeast were done before doing Diacetyl rest but I sometimes had issues with Diacetyl so I researched it and saw that some people start ramping the temp up once the activity is noticeably slower, say 75% done. It makes intuitive sense that the yeast might clean up Diacetyl precursors faster or better if you increase temp before they fall asleep but on the other hand maybe they'll make a cleaner beer if you let them finish eating the sugars before ramping up the temp. I haven't made enough lagers to be sure whether or not it has helped and I've never seen good data regarding which is the best approach. Having said that, lately I've been ramping temp up from 50 to 65 over a period of a few days, starting when beer is 75% of the the way to final gravity.