Search results

Somewhere along the Snake River?

Every year for her birthday, we get a bouncy castle filled with hydrogen. Oh the humanity!

@cmac62 beat me to it...

My two 20lb CO2 tanks are stored in the basement and we have a nine-year old kid. The concern is a silent leak or burst disk rupturing when no one is around and the kid walking into toxic level of CO2 in the basement, given the relatively poor ventilation when the fan is off. Of all the things...

Also @Thorrak is definitely off the hook 😀

OK, I couldn't let this go... I blame this for giving me nightmares when I was a kid about not fixing things properly... The last bug was in the parsing of HWVer. The code was doing nested if loops to check the hardware version. The way it was implemented was: if ( key1 exists ): if (...

Thanks @gromitdj that was fun!

Hold off merging... there is another piece to this...

OK, pull request is in. Just tested it with the procedure I used to trigger the bug the first time and it looks good. @LBussy you needs both this patch and the original one to fix the int() bug. I just realized that I based this pull request on your main branch, not the tiltfix branch. GitHub...

@LBussy I know what the real bug is. There is a loop that start on line 1892 for color in Tilt.TILT_COLORS that tries to parse through and get the information from the tilt that matches config['tiltColor']. When this loop is done, color contains Pink, since that's the last color in TILT_COLORS...

I pick @orionol73 (but I found @LBussy's bug!)

While simultaneously debugging BrewPi Remix 😅

OK, caught it in action... 2022-05-09 18:55:42 [N] 0.7.6 (master) [b144360] 2022-05-09 18:55:42 [N] Starting '044-ill-have-an-otter.' 2022-05-09 18:55:42 [N] Opening serial port. 2022-05-09 18:55:42 [N] Waiting 10 seconds for board to restart. 2022-05-09 18:55:52 [N] Checking software version...

Ah, ha, figured out the bug! To trigger it, you need to: Have TiltBridge sending data correctly for you tilt color for the brew. Have TiltBridge loose the tilt connection and send a JSON containing {"mdns_id": "tiltbridge", "tilts": null} Restart the BrewPi script while the contents of the...

I’ve gone back to the old version of the code and moved my tiltbridge upstairs to try and reproduce the error. So far, it’s cycling between displaying the previous good values and nothing each time it gets an empty update from TiltBridge: 2022-05-09 16:01:59 [N] API TB JSON Recvd: {"mdns_id"...

I’ve cleared my evening for a live pick!

@athistle in the mean time, please can you look at the stdout and stderr logs and send a screen shot? It shouldn't be crashing now, at least.

Ah, I thought there might be one more edge case... if you restart brewpi with bad tilt data in the JSON from prior to the bug, it will do this. Let me see if I can come up with a fix for that.

@athistle if the git restore fails for you, your pi may have an older version of git (mine has 2.20.1 and restore was introduced in 2.23.0). The commands below do the same thing: cd /home/brewpi sudo git reset --hard HEAD sudo git fetch -a sudo git checkout -b tiltfix origin/tiltfix sudo...